Coroutines support#57
Conversation
3a29f20 to
ed1d2b7
Compare
|
@Nek-12 Maybe you would like to have a look on this work. I worked with coroutines some time ago |
| var snapshot: CodeSnapshot? = null | ||
| private set | ||
|
|
||
| var analysisJob: Job? = null |
There was a problem hiding this comment.
This assignment is not thread safe and can leak, I'd recommend to avoid storing a job. See my comment below for a suggestion.
There was a problem hiding this comment.
I see, this is probably to change
|
Want me to propose another variant of the API? |
Yes please |
ed1d2b7 to
8ddbf42
Compare
|
You are making a lot of changes, should I still work on this? |
|
I have applied some of your suggestions and only changed small things like unit tests. I don't know if you have branched from commit, copied code or created new branch from scratch. I am experimenting and testing this code with Dart and Swift. If you plan to make big changes in API create a separate PR even if this is this branch based |
|
@Nek-12 Hi, did you manage to create any POC? :) |
|
Hi, I assumed that since you are making changes I should wait 😅. Can you help me understand how you want that to be done? Should I fork and open another PR into release/1.0.0 or into this branch? |
|
Okay 😄 I tried creating a public API with Kotlin Flow but this works best when client side also implements Flow library and this is not my intention. Nevertheless I am very happy to see your approach. Please create a PR pointing to release/1.0.0 with your idea. Grab the enough amount of code from me or write from scratch ;) |
No description provided.