issue-create: add open-questions resolution pass; drop handoff prompt#77
Merged
Conversation
Inserts a new Stage 3.3 between draft render and approval that walks each Open questions item with a stated lean (or "no lean — your call") and re-renders with resolutions baked into Scope / Hints / Acceptance. Strips the "Start working on this now?" prompt and conditional /issue-work invocation from Stage 4.7; the Pairs with relationship survives but the auto-handoff mechanism does not. Stage 4 + 4.7 titles trimmed since "& hand off" / "+ handoff" are no longer accurate. Resolves #70.
- Drop "(or equivalent free-form open-ended)" parenthetical from the
template-derived-draft sentence so the detection trigger stays bound
to the plan's literal "Open questions" non-goal.
- Add a data-anchoring sentence after the per-question prompt so an
instruction-shaped {question text} is treated as content, not as an
instruction (matters when the draft was templated from a third-party
repo).
- Complete the "On `yes` ..." sentence fragment with an explicit
predicate so the LLM doesn't have to reconstruct intent.
Findings from /pr-self-review on 17564ca.
SnowboardTechie
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a collaborative open-questions resolution pass to the
/issue-createskill: when the rendered draft contains anOpen questionssection, the skill walks each item with a stated lean (or "no lean — your call"), acceptsconfirm/override <text>/defer, and re-renders with resolutions baked into Scope / Hints / Acceptance. Strips the post-create "Start working on this now?" handoff prompt — fresh-context/issue-workagents are the right shape for implementation work, and the auto-prompt was always declined.Closes #70.
Test plan
SKILL.mdend-to-end after edits — new Stage 3.3 flow is unambiguous (detection trigger, lean priority, per-question shape, default-commit rule, deferred-marker, misfit-prompt, re-render rules, zero-questions short-circuit),3.3 → 3.4renumber clean, Stage 4.7 report block intact (handoff tail removed), line 10 + Related entry rewritten for manual pairing, CHANGELOG entry observable-change framing./pr-self-reviewinpre-prmode) — pass 1: 1 Major + 2 Minor + 2 Nit; three findings accepted in commit8795449, one pushed back (CHANGELOGResolvesmatches repo convention; issue-create: default to collaborative open-questions pass; drop post-create issue-work handoff #70 should auto-close), one skipped (Stage 4 heading drift-fix; reviewer agreed). Pass 2: 0/0/0/0 across correctness / security / simplicity. Loop exit clean./issue-createinvocation.Changelog
## [Unreleased]inCHANGELOG.md.