bootstrap: resolve add/add conflict and land product-service ontology tranche#12
bootstrap: resolve add/add conflict and land product-service ontology tranche#12
Conversation
…logy tranche Merge origin/bootstrap/product-service-tranche-v0-1 into copilot/bootstrap-fix-merge-conflicts. Conflict resolution in shapes/product-service.shacl.ttl: - Replaced generic ps:OfferingShape (targeting biz:Offering) from main with the more specific ps:ProductOfferingShape and ps:ServiceOfferingShape from the PR branch, targeting ps:ProductOffering and ps:ServiceOffering respectively, consistent with Domains/product-service.ttl class hierarchy. Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
|
@copilot fix failed checks and conflicts |
Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Resolves the prior add/add merge conflict in product-service SHACL shapes and lands the product-service ontology tranche wiring (registry + SHACL gates + docs + integrity test) so the tranche is consistently validated by the repo’s standard validation pipeline.
Changes:
- Resolves offering-level SHACL conflict by targeting
ps:ProductOffering/ps:ServiceOfferingdirectly instead ofbiz:Offering. - Registers the business-core and product-service domain modules in the TTL and JSON-LD registries and updates module map/docs.
- Adds a product-service SPARQL integrity invariant test and extends
shapes/ontogenesis.shacl.ttlwith product-service gates.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/product-service-integrity.rq | Adds SPARQL invariant checks for canonical product-service example individuals. |
| shapes/product-service.shacl.ttl | Resolves offering-shape conflict by introducing separate product vs service offering node shapes. |
| shapes/ontogenesis.shacl.ttl | Extends the primary validation SHACL bundle with product-service shapes (offerings/plan/capability/instance). |
| docs/product-service-tranche-note.md | Adds tranche design/integration note for product-service. |
| docs/module-map.md | Updates domain listing and documents SHACL bundle inventory. |
| catalog/registry.ttl | Registers Domains/business_core.ttl and Domains/product-service.ttl modules in the Turtle registry. |
| catalog/registry.jsonld | Registers Domains/business_core.ttl and Domains/product-service.ttl modules in the JSON-LD registry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,38 @@ | |||
| PREFIX biz: <https://socioprophet.github.io/ontogenesis/domains/business#> | |||
There was a problem hiding this comment.
biz: prefix is declared but not used anywhere in this query; removing it would keep the test file minimal and consistent with other integrity queries.
| PREFIX biz: <https://socioprophet.github.io/ontogenesis/domains/business#> |
Resolve conflicts: - .github/workflows/validate.yml: accept main's split make venv + make deps steps - shapes/product-service.shacl.ttl: include both specific subclass shapes (ps:ProductOfferingShape, ps:ServiceOfferingShape) and base class shape (ps:OfferingShape targeting biz:Offering) from main Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Fixed in 4224c7a. The Also merged the latest |
PR #10 (
bootstrap/product-service-tranche-v0-1) was blocked by an add/add conflict inshapes/product-service.shacl.ttlcaused by a diverged earlier merge of product-service intomain(PR #7).Conflict resolution
shapes/product-service.shacl.ttlhad two incompatible shape definitions at the offering level:Accepted the PR branch version —
ps:ProductOfferingandps:ServiceOfferingare explicit subclasses ofbiz:OfferinginDomains/product-service.ttl, so targeting them directly is semantically correct and consistent with the rest of the tranche.Integrated files from PR #10
catalog/registry.{ttl,jsonld}—DomainBusinessCoreandDomainProductServicemodule entriesshapes/ontogenesis.shacl.ttl— product-service SHACL gates (ps:prefixes, offering/plan/capability/instance shapes)shapes/product-service.shacl.ttl— conflict resolved as abovedocs/module-map.md— domain listing and SHACL bundle list updateddocs/product-service-tranche-note.md— tranche design note (new)tests/product-service-integrity.rq— SPARQL integrity test (new)Original prompt
This pull request was created from Copilot chat.