feat: socket fees support#109
Merged
tHeMaskedMan981 merged 7 commits intofix/evmx-contextfrom Apr 21, 2025
Merged
Conversation
arthcp
reviewed
Apr 14, 2025
contracts/protocol/socket/Socket.sol
Outdated
Comment on lines
69
to
74
| if (address(socketFeeManager) != address(0)) { | ||
| socketFeeManager.payAndCheckFees{value: transmissionParams_.socketFees}( | ||
| executeParams_, | ||
| transmissionParams_ | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
if we set socketFeeManager to non zero addess it will make the slot hot and help us with gas
ameeshaagrawal
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.