Skip to content

Update draw function of shell #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
antennae wants to merge 4 commits into
base: legacy
Choose a base branch
from
Open

Update draw function of shell #10

antennae wants to merge 4 commits into from

Conversation

@antennae
Copy link
Contributor

@antennae antennae commented Apr 9, 2025 •
edited
Loading

This update enhances the draw function of TriangularShellForceField to:

  • Render the shell as a continuous surface instead of discrete axes
  • Visualize stress data as a heatmap on the shell surface

alxbilger
alxbilger requested changes Apr 9, 2025
View reviewed changes
src/SofaShells/forcefield/TriangularShellForceField.h Outdated
TRQSTriangleHandler* triangleHandler;

private:
sofa::helper::ColorMap* p_drawColorMap; ///< colormap to display the gradiant of stress if @sa showStressValue is set to true
Copy link
Member

@alxbilger alxbilger Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use a pointer here. Moreover, it's not even destroyed. So use a simple data member as an object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxbilger alxbilger alxbilger requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antennae @alxbilger