Add swagger doc#70
Merged
andrewmarklloyd merged 2 commits intoApr 9, 2018
Merged
Conversation
Contributor
|
Looking good so far @abdulbasitkay! I started a review and I have a few notes here:
|
Contributor
Author
|
Thanks for the feedback @andrewmarklloyd, |
Contributor
|
Sorry about that, you're right I meant |
Contributor
|
Let's merge this in and we can add a new issue to add docs for |
andrewmarklloyd
suggested changes
Apr 9, 2018
| example: 1522767185 | ||
| eventData: | ||
| type: object | ||
| description: raw data of the event being streamed |
Contributor
There was a problem hiding this comment.
The eventData maps to a specific eventType's required keys. For example the playEpisode eventType eventData has 3 fields: episodeName, minutesPlayed, and minutesRemaining. I would add an example, like:
example: {
episodeName: "Ethereum Governance with Hudson Jameson",
minutesPlayed: 1622.53,
minutesRemaining: 117.62
}
andrewmarklloyd
approved these changes
Apr 9, 2018
Contributor
|
Created a new issue #73 |
andrewmarklloyd
added a commit
that referenced
this pull request
Apr 21, 2018
* Add script to build coverage badge for README * Use Webtask API to update coverage badge * Update README.md * Add a field to identify the environment (Test or Prod) (#67) * Add unit tests * Store errors in DB with each field separately. Allow error types authorization and other for now. Build InfluxDB fields using the param-validation schema (#71) * Add swagger doc (#70) * Update moment dependency to 2.19.3 (#75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt at #59, hope this works