Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ PR Summary
🌟 요약
어떤 것이 변경되었나요? 간략히 설명해주세요.
KisPendingOrder프로토콜에KisOrder를 지원하도록 변경하였습니다.📊 주요 변경 사항
주요 변경 사항을 적어주세요.
pykis/adapter/account_product/order_modify.py파일을 추가했습니다.KisCancelableOrder,KisModifyableOrder,KisOrderableOrder프로토콜 및 Mixin을 추가했습니다.pykis/adapter/websocket/execution.py파일의KisRealtimeOrderableOrder에 실시간 체결 조회 관련 함수를 추가하고, 기존KisOrderBase에 해당 Mixin을 사용하였습니다.pykis/api/account/pending_order.py파일의KisPendingOrder프로토콜에KisOrder프로토콜을 상속받도록 변경하고 KisPendingOrderBase에 해당 스펙을 충족하도록 구현하였습니다.pykis/api/account/order.py파일의KisOrderNumberBase.__eq__함수에서 숫자 포메팅에 의한 불일치를 수정했습니다.🎯 목적 및 영향
목적: 왜 이 PR이 필요한가요?
PyKis의 예제 코드처럼
pending_orders를 조회하고KisPendingOrder객체에 바로cancel및modify를 호출할 수 있도록 변경하였습니다.영향: 이 변경 사항이 어떤 영향을 미치나요?
KisPendingOrder는 이제KisOrder를 상속받습니다.실시간 주문번호 필터링이 의도대로 작동합니다.