Fix emmc values for veyron-mickey in install scripts#260
Fix emmc values for veyron-mickey in install scripts#260SolidEva merged 1 commit intoSolidEva:masterfrom
Conversation
| $device_veyron_speedy) local devname=mmcblk2;; | ||
| $device_veyron_minnie) local devname=mmcblk2;; | ||
| $device_veyron_mickey) local devname=mmcblk2;; | ||
| $device_veyron_mickey) local devname=mmcblk1;; |
There was a problem hiding this comment.
Could you use spaces instead of tabs for consistency with the rest of the code?
There was a problem hiding this comment.
Absolutely. Didn't catch that in the terminal, tab aligned while editing there. Will adjust.
| $device_veyron_speedy) local devname=mmcblk2;; | ||
| $device_veyron_minnie) local devname=mmcblk2;; | ||
| $device_veyron_mickey) local devname=mmcblk2;; | ||
| $device_veyron_mickey) local devname=mmcblk1;; |
There was a problem hiding this comment.
Done. Thanks for the help!
eb52d2d to
7a8937d
Compare
|
this whole mmc vs sd mapping thing is pretty obnoxious. tempted to write some kernel patches to make this consistent. For now this looks great, thanks @gregordinary ! Thanks for the review @austin987 |
|
I believe the reason the veyron_mickey aka Chromebit CS10 is different is because it does NOT have a microSD slot, only the internal eMMC and a USB2.0 port, so it can never flip-flop the order of the devices depending on what device/kernel it boots from. |
|
@espoelstra Ccould be why. Realizing now, it probably follows that the entry for Mickey under get_sd_devname should be removed. |
@rk-zero noted the value for the emmc on veyron-mickey was mmcblk1, unlike other veyron devices (so far) which is mmcblk2. This pull request changes the emmc value for veyron-mickey in InstallPrawnOS.sh and InstallPackages.sh to reflect mmcblk1.
Also double checked the output of fdisk -l on the cs10 and c100, which both still have ChromeOS on the emmc and confirmed the mmcblk1 vs mmcblk2 values, respectively.
Veyron-Mickey / CS10:
Veyron-Minnie / C100: