-
Notifications
You must be signed in to change notification settings - Fork 3
Add unit tests #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #59
Conversation
termontwouter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one major remark: opaque token handling was absolutely not a "leftover", so I'm not sure why you would remove it ... Ideally, tokens are opaque and only the AS knows their meaning. Transmitting the related info in a JWT is handy for development, but is less secure, and should probably not be used in a production environment.
I don't fully remember any more, but I think I removed it based on the comments that were there and that I didn't see it used, with the idea that it can be added back once it was actually used. But I can have another look into how much of it can be salvaged already. |
And add some minor cleanups
e02bb33 to
b7ca19d
Compare
Adding unit tests and cleaning up the corresponding the classes in the process when necessary.
WIP. Finished for the CSS components.