Skip to content

Conversation

@joachimvh
Copy link
Contributor

Adding unit tests and cleaning up the corresponding the classes in the process when necessary.

WIP. Finished for the CSS components.

@joachimvh joachimvh marked this pull request as draft August 8, 2025 08:46
@joachimvh joachimvh marked this pull request as ready for review August 27, 2025 13:20
Copy link
Collaborator

@termontwouter termontwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one major remark: opaque token handling was absolutely not a "leftover", so I'm not sure why you would remove it ... Ideally, tokens are opaque and only the AS knows their meaning. Transmitting the related info in a JWT is handy for development, but is less secure, and should probably not be used in a production environment.

@joachimvh
Copy link
Contributor Author

Just one major remark: opaque token handling was absolutely not a "leftover", so I'm not sure why you would remove it ... Ideally, tokens are opaque and only the AS knows their meaning. Transmitting the related info in a JWT is handy for development, but is less secure, and should probably not be used in a production environment.

I don't fully remember any more, but I think I removed it based on the comments that were there and that I didn't see it used, with the idea that it can be added back once it was actually used. But I can have another look into how much of it can be salvaged already.

@joachimvh joachimvh merged commit 707a1f8 into main Sep 18, 2025
5 of 6 checks passed
@joachimvh joachimvh deleted the test/unit branch September 18, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants