Fix several minor issues #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return ({ | ||
| status: 201, | ||
| headers: { location: `${joinUrl(request.url.href, encodeURIComponent(resource))}` }, |
Collaborator
There was a problem hiding this comment.
Why do you use the request URL as base, instead of the endpoint URL from config? I know they're probably the same, but source-of-truth-wise it feels a bit weird this way...
Contributor
Author
There was a problem hiding this comment.
Because this was easier from a dependency point of view 😅
termontwouter
previously approved these changes
Sep 9, 2025
joachimvh
force-pushed
the
test/unit
branch
from
e02bb33 to
b7ca19d
Compare
joachimvh
force-pushed
the
fix/issues
branch
from
e1ea10b to
98cb6b3
Compare
joachimvh
dismissed
termontwouter’s stale review
The base branch was changed.
joachimvh
force-pushed
the
fix/issues
branch
from
98cb6b3 to
d7fb373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting the test/unit branch due to the many changes that are already there.