Skip to content

Avoid BlankNodes inside PATCHes #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bourgeoa merged 3 commits into from
Jan 15, 2025
Merged

Avoid BlankNodes inside PATCHes #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38a84b0
Avoid BlankNodes inside PATCHes
michielbdejong Nov 26, 2024
c12c272
NamedNode for fragment in profile doc
michielbdejong Nov 26, 2024
7fd4c51
Fix DOMPurify import to adhere to https://www.npmjs.com/package/dompu…
michielbdejong Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/humanReadablePane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { icons, ns } from 'solid-ui'
import { Util } from 'rdflib'
import { marked } from 'marked'
import * as DOMPurify from 'dompurify'
import DOMPurify from 'dompurify';

const humanReadablePane = {
icon: icons.originalIconBase + 'tango/22-text-x-generic.png',
Expand Down
40 changes: 16 additions & 24 deletions src/trustedApplications/__snapshots__/trustedApplications.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ exports[`getStatementsToAdd should return all required statements to add the giv
"termType": "NamedNode",
"value": "https://profile.example",
},
"object": BlankNode {
"classOrder": 6,
"isBlank": 1,
"isVar": 1,
"termType": "BlankNode",
"value": "bn_mock_app_id",
"object": NamedNode {
"classOrder": 5,
"termType": "NamedNode",
"value": "https://profile.example#mock_app_id",
},
"predicate": NamedNode {
"classOrder": 5,
Expand Down Expand Up @@ -42,12 +40,10 @@ exports[`getStatementsToAdd should return all required statements to add the giv
"termType": "NamedNode",
"value": "http://www.w3.org/ns/auth/acl#origin",
},
"subject": BlankNode {
"classOrder": 6,
"isBlank": 1,
"isVar": 1,
"termType": "BlankNode",
"value": "bn_mock_app_id",
"subject": NamedNode {
"classOrder": 5,
"termType": "NamedNode",
"value": "https://profile.example#mock_app_id",
},
},
Statement {
Expand All @@ -66,12 +62,10 @@ exports[`getStatementsToAdd should return all required statements to add the giv
"termType": "NamedNode",
"value": "http://www.w3.org/ns/auth/acl#mode",
},
"subject": BlankNode {
"classOrder": 6,
"isBlank": 1,
"isVar": 1,
"termType": "BlankNode",
"value": "bn_mock_app_id",
"subject": NamedNode {
"classOrder": 5,
"termType": "NamedNode",
"value": "https://profile.example#mock_app_id",
},
},
Statement {
Expand All @@ -90,12 +84,10 @@ exports[`getStatementsToAdd should return all required statements to add the giv
"termType": "NamedNode",
"value": "http://www.w3.org/ns/auth/acl#mode",
},
"subject": BlankNode {
"classOrder": 6,
"isBlank": 1,
"isVar": 1,
"termType": "BlankNode",
"value": "bn_mock_app_id",
"subject": NamedNode {
"classOrder": 5,
"termType": "NamedNode",
"value": "https://profile.example#mock_app_id",
},
},
]
Expand Down
2 changes: 1 addition & 1 deletion src/trustedApplications/trustedApplications.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function getStatementsToAdd (
person: NamedNode,
ns: Namespaces
): any {
const application = new BlankNode(`bn_${nodeName}`)
const application = new NamedNode(`${person.doc().uri}#${nodeName}`)
return [
st(person, ns.acl('trustedApp'), application, person.doc()),
st(application, ns.acl('origin'), origin, person.doc()),
Expand Down