Removed slow subquery from albums view

[gs11]

Fix for issue #279

Opened new PR to change source branch. Old PR #283

[lGuillaume124]

I already tried to remove this ugly request, but you can't doing it this way.
This doesn't work with PostreSQL.

[lGuillaume124]

In fact the whole database schema is very ugly... We took a very bad decision at the early beginning of this project.

[MightyCreak]

Considering the improvement that this PR provides, I think it would be interesting to consider dropping PostgreSQL support (until it gets fixed). Now that I run Sonerezh with this commit, I just don't want to come back.

[gs11]

I'll look into getting a postgres solution to work. In worst case the subquery could be postgres specific code.

[gs11]

The issue seems to be that the code is not SQL-92 compatible @lGuillaume124. PostgreSQL is strict on this as opposed to earlier versions of MySQL.
I did a fix for that in a later commit in my repo https://github.com/gs11/sonerezh/commit/4558290ae5d25b324af8ed067a15b276f9b2bee6

Either I could do a PR from my whole development-new branch to merge all newer changes (including this). See full list of changes from the original sonerezh development branch here:
https://github.com/gs11/sonerezh

Otherwise I could either update this PR with the SQL-92 compliance changes or create a new PR. The first suggestion would be the easiest of course.

[gs11]

PostgreSQL just verified to work fine with my development-new branch.

[lGuillaume124]

Great! If it doesn't bother you I prefer you to update this PR :)
We'll be happy to accept your contributions but there is a lot to review and test and I prefer small PR instead of big ones :)

[gs11]

Rebased and amended. Now works for MySQL, PostgreSQL & Sqlite. (removed the sqlite specific code since the same code works for all three db types) @lGuillaume124

Also, this includes the code in PR #304 (issue #270) since it isn't possible to exclude the group by band (SQL-92 compliance).

[JocelynDelalande]

bump :). Any reasons left not to merge ?

On a large collection (~10Gb of music), the slow query gets the cpu to 100% and crashes the app

[gs11]

Unfortunately it's now been close to 8 months since the last activity here. @JocelynDelalande
See this issue on the project status: #297

My own branch/fork has a number of fixes (for this issue among others) & feature additions. Until the sonerezh devs have time available, I'd advise you to run this branch and report any issues there.

[gs11]

Already merged as part of #339