Skip to content

Fix #277 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GaneshKandu wants to merge 3 commits into from
Closed

Fix #277 #318

GaneshKandu wants to merge 3 commits into from

Conversation

@GaneshKandu
Copy link
Contributor

@GaneshKandu GaneshKandu commented Jul 6, 2017

@GaneshKandu GaneshKandu changed the title "Undefine index: id" notice in install Fix #277 Jul 6, 2017
@MightyCreak
Copy link
Contributor

MightyCreak commented Jul 6, 2017

I'd suggest you replace the tabs with spaces like it was before, please.
Mixing the two always leads to problems, as we can see here, the diff is hard to read.
Thanks

@MightyCreak
Copy link
Contributor

MightyCreak commented Jul 6, 2017

Could you propose the patch to @gs11's fork? https://github.com/gs11/sonerezh
It already has a bunch of features and fixes on top of the official dev branch.

@GaneshKandu
Fix #277
689b865 
Fix #277
@GaneshKandu
fiexd spaces
3c65be3 
fiexd spaces
@lGuillaume124 lGuillaume124 added this to the 1.1.4 milestone Jul 14, 2017
@lGuillaume124
Copy link
Contributor

lGuillaume124 commented Jul 14, 2017

Merged to development. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaneshKandu @MightyCreak @lGuillaume124