🔒 Fix sensitive OAuth token partial exposure in logs#16
Conversation
This change removes the logging of the first 20 characters of the OAuth access token during verification. Logging sensitive tokens, even partially, is a security risk. - Removed token substring logging in `packages/core/src/mcp/oauth-provider.ts` - Added `packages/core/src/mcp/oauth-provider-security.test.ts` to verify the fix and prevent regression. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed a security vulnerability where a partial OAuth access token was being logged to the console.
🛡️ Solution: Removed the logging of the token substring and replaced it with a generic success message. Added a new security-focused test file to ensure the token is never logged.
PR created automatically by Jules for task 10411736675007371156 started by @TrueAlpha-spiral