🔒 fix command injection in sandbox proxy command execution#55
🔒 fix command injection in sandbox proxy command execution#55TrueAlpha-spiral wants to merge 1 commit intomainfrom
Conversation
Using `shell: true` when executing commands from external sources like environment variables is a command injection vector. This fix parses the `GEMINI_SANDBOX_PROXY_COMMAND` environment variable using `shell-quote` and executes it directly without a shell. 🎯 **What:** The vulnerability fixed is a command injection in the sandbox proxy execution.⚠️ **Risk:** An attacker who can control the `GEMINI_SANDBOX_PROXY_COMMAND` environment variable could execute arbitrary commands on the host system. 🛡️ **Solution:** The `proxyCommand` is now parsed into an argument array and passed to `spawn` with `shell: false` (the default). Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The vulnerability was located in
packages/cli/src/utils/sandbox.tswherespawnwas called withshell: trueusing a command string from theGEMINI_SANDBOX_PROXY_COMMANDenvironment variable. This allowed for command injection.The fix involves:
proxyCommandstring into an array of arguments using theparsefunction from theshell-quotelibrary.|,&&, etc. thatshell-quotemight identify).spawnwith the parsed command and arguments, and removing theshell: trueoption.A reproduction security test was added in
packages/cli/src/utils/sandbox_repro.security.test.tsto verify the fix.PR created automatically by Jules for task 16733833787291557428 started by @TrueAlpha-spiral