Skip to content

🧪 test: Add unit tests for getIdeDisplayName and detectIde in core#57

Draft
TrueAlpha-spiral wants to merge 1 commit intomainfrom
test-ide-detect-8252235490452098005
Draft

🧪 test: Add unit tests for getIdeDisplayName and detectIde in core#57
TrueAlpha-spiral wants to merge 1 commit intomainfrom
test-ide-detect-8252235490452098005

Conversation

@TrueAlpha-spiral
Copy link
Copy Markdown
Collaborator

🎯 What: The lack of test coverage for the simple getIdeDisplayName and detectIde functions in packages/core/src/ide/detect-ide.ts has been addressed.
📊 Coverage: The new tests in packages/core/src/ide/detect-ide.test.ts verify the DetectedIde.VSCode case for getIdeDisplayName. Furthermore, test coverage has been provided for detectIde using Vitest's vi.stubEnv to cover cases where TERM_PROGRAM is "vscode", something else, or undefined.
Result: Test coverage for packages/core/src/ide/detect-ide.ts is vastly improved. Code regressions in these functions will now be caught, and new IDE cases added to the enum will be properly unit-testable.


PR created automatically by Jules for task 8252235490452098005 started by @TrueAlpha-spiral

This commit adds a new test file, `packages/core/src/ide/detect-ide.test.ts`,
which tests the `getIdeDisplayName` and `detectIde` functions. The tests cover
the current single implementation case for VS Code and utilize `vi.stubEnv` to
effectively verify the environment-based detection logic.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant