Skip to content

🧪 test: add tests for getEventMetadataKey#63

Draft
TrueAlpha-spiral wants to merge 1 commit intomainfrom
add-tests-get-event-metadata-key-8138350412462185464
Draft

🧪 test: add tests for getEventMetadataKey#63
TrueAlpha-spiral wants to merge 1 commit intomainfrom
add-tests-get-event-metadata-key-8138350412462185464

Conversation

@TrueAlpha-spiral
Copy link
Copy Markdown
Collaborator

🎯 What: The testing gap addressed was the lack of unit tests for getEventMetadataKey inside packages/core/src/telemetry/clearcut-logger/event-metadata-key.ts.
📊 Coverage: Scenarios now tested include valid enum key strings, invalid key strings, string-casted numbers (e.g. "1"), and built-in object prototype properties.
Result: Test coverage improved for the telemetry logger and mapping edge-cases are now explicitly prevented via tests.


PR created automatically by Jules for task 8138350412462185464 started by @TrueAlpha-spiral

Add vitest test file for `getEventMetadataKey` in `packages/core/src/telemetry/clearcut-logger/event-metadata-key.test.ts` to ensure mapping string keys to Clearcut logging enum values works properly, handling edge cases such as numeric strings and prototype properties correctly.
Also fixed a minor ESM extension issue in `utils/errors.test.ts`.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant