Skip to content

fix: Cast EventEmitters to stream type in shellExecutionService test#71

Open
TrueAlpha-spiral wants to merge 1 commit intomainfrom
jules-9862923026598603887-47bc50cc
Open

fix: Cast EventEmitters to stream type in shellExecutionService test#71
TrueAlpha-spiral wants to merge 1 commit intomainfrom
jules-9862923026598603887-47bc50cc

Conversation

@TrueAlpha-spiral
Copy link
Copy Markdown
Collaborator

This PR fixes a TypeScript type mismatch in packages/core/src/services/shellExecutionService.test.ts. Specifically, the mock child process's stdout and stderr were assigned simple EventEmitter instances, but they need to be treated as Readable streams. The fix applies as unknown as Readable casts to satisfy the expected types and cleans up the associated // FIX comment. All tests pass successfully.


PR created automatically by Jules for task 9862923026598603887 started by @TrueAlpha-spiral

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@TrueAlpha-spiral TrueAlpha-spiral marked this pull request as ready for review March 29, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant