Skip to content

fix: Safely resolve canonical realpaths for symlinks#74

Draft
TrueAlpha-spiral wants to merge 1 commit intomainfrom
fix/symlink-realpath-handling-215401694206377659
Draft

fix: Safely resolve canonical realpaths for symlinks#74
TrueAlpha-spiral wants to merge 1 commit intomainfrom
fix/symlink-realpath-handling-215401694206377659

Conversation

@TrueAlpha-spiral
Copy link
Copy Markdown
Collaborator

Fix issue in packages/cli/src/config/config.ts where fs.realpathSync could throw exceptions for missing paths. By using a wrapper resolveRealpath with a try-catch, we gracefully handle non-existent directories falling back to path.resolve outputs without unhandled exceptions. All unit and integration tests successfully pass.


PR created automatically by Jules for task 215401694206377659 started by @TrueAlpha-spiral

Wrap fs.realpathSync in a helper function (resolveRealpath) to gracefully fallback to the regular resolved path if realpathSync fails (e.g., throwing ENOENT when the directory does not exist). This robustly handles the comparison for determining isHomeDirectory in the CLI config while handling symlinks as intended.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant