Skip to content

🔒 fix: Unsafe JSON Parsing in Restore Command#77

Draft
TrueAlpha-spiral wants to merge 1 commit intomainfrom
fix/restore-command-zod-schema-2251652087094023051
Draft

🔒 fix: Unsafe JSON Parsing in Restore Command#77
TrueAlpha-spiral wants to merge 1 commit intomainfrom
fix/restore-command-zod-schema-2251652087094023051

Conversation

@TrueAlpha-spiral
Copy link
Copy Markdown
Collaborator

🎯 What: The restoreCommand previously parsed checkpoint files from disk directly using JSON.parse and assumed the shape of the data without runtime validation, which could be a localized security risk if a checkpoint file is maliciously crafted or corrupted.

⚠️ Risk: While localized to the user's .gemini/checkpoints environment, parsing unsanitized JSON and directly reading arbitrary object properties (like history and toolCall.name) could lead to unexpected behavior, prototype pollution vectors, or unhandled exceptions crashing the application.

🛡️ Solution: Implemented robust schema validation using zod in packages/cli/src/ui/commands/restoreCommand.ts. The parsed data is now passed through toolCallDataSchema.parse() to ensure it strictly conforms to the expected structure before any data properties are accessed. Missing required properties (like toolCall) are caught gracefully and return an explicit error instead of causing unhandled runtime crashes. Tests in restoreCommand.test.ts have been updated to expect the safer, more explicit error handling.


PR created automatically by Jules for task 2251652087094023051 started by @TrueAlpha-spiral

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant