Skip to content

Conversation

@WheezeNL
Copy link
Contributor

If you're adding a new endpoint make sure that

Copy link
Member

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. However, two things about your endpoint:

  • You're not setting a CORS header, preventing your endpoint from being used by browser-based SpaceAPI clients. Implementing this is as simple as setting an Access-Control-Allow-Origin: * header in your endpoint's HTTP response.
  • SpaceAPI v14 and later only use the api_compatibility field. The api field (that you set to 15) was only used until v0.13. The fact that the validator currently accepts this is unintended. I recommend you remove the api field from your endpoint.

@s3lph s3lph merged commit 767dd67 into SpaceApi:master Oct 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants