Skip to content

Fix incorrect documentation about rollback behavior in database transactions section #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hohanov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect documentation about rollback behavior in database transactions section #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3.1/imports/validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function customValidationAttributes()

### Database transactions

The entire import is automatically wrapped in a **database transaction**, that means that *every* error will rollback the entire import. When using batch inserts, only the **current** batch will be rollbacked.
The entire import is automatically wrapped in a **database transaction**, that means that *every* error will rollback the entire import (even when using batch inserts).

#### Disable transactions

Expand Down
2 changes: 1 addition & 1 deletion 4.x/imports/validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public function customValidationAttributes()

### Database transactions

The entire import is automatically wrapped in a **database transaction**, that means that *every* error will rollback the entire import. When using batch inserts, only the **current** batch will be rollbacked.
The entire import is automatically wrapped in a **database transaction**, that means that *every* error will rollback the entire import (even when using batch inserts).

#### Disable transactions

Expand Down