Is there a way to add spell cast flood protection back?

[a1exp]

In Sphere 56b when you press and hold a client macro like (cast spell hea, target self) number of lines for spell cast is limited to 3.

In SphreX (actually started with Sphere 56c) you will see spam. Players are complaining thata "casts are flying away up" :). You will not notice such thing on Orion, only on default client (I used 5.0.6 and 2.0.3 for tests).

This might seems like a client issue, but Sphere 56b somehow protected from it. You can see videos below.

56b:
https://user-images.githubusercontent.com/31130012/138567443-475c462b-776e-4673-8ce0-c8591100f5fd.mp4

SphereX:
https://user-images.githubusercontent.com/31130012/138567454-398a3705-1a15-4556-9be6-19737deb7e03.mp4

[Jhobean]

This do not happen on orion client. The "fix" I reverted last week ( f24687c) caused this.
We should fix it differently than it was before but I dont know how. Maybe add a delay between 2 packet? Its strange it do not happennon 56b... They use speach spell mode?

[a1exp]

@Jhobean
Seems yes https://github.com/Sphereserver/Source/blob/9b2521d05858258d1b3bb7d1a06fb48236e57404/graysvr/CCharSpell.cpp#L2303

Briefly looking thwough the code, I can't find a place where sphere does flood ptotection for TALKMODE_SAY. Is it possible to be a client-side protection but only for this talk mode?

[Jhobean]

I dont think It's client side protection because you had same client with 56b

On the part of code you posted, 56b seem to use talkmode say too. But with talkmode say, you cant choose color of WOP...

[Leodinas]

Speak((pSpellDef->m_sRunes.GetBuffer()) + 1, (HUE_TYPE)WOPColor, TALKMODE_SPELL, (FONT_TYPE)WOPFont);
change
Speak((pSpellDef->m_sRunes.GetBuffer()) + 1, (HUE_TYPE)WOPColor, TALKMODE_SAY, (FONT_TYPE)WOPFont);

[Jhobean]

@Leodinas yes its the old fix. But it cause other issue that he reported.
#776

[xwerswoodx]

Best way we could do it, we can add flag for it, so you can choose to use TALKMODE_SAY or TALKMODE_SPELL, because we could add flood protection in sphere-side but what we can do best is just blocking if already has 3 lines in your screen, but that can cause so many issues, for example, if you used nightsight spell and use paralyze spell on someone, if we add block players couldn't see An Ex Por lines but still get paralyzed. This issue is totally client-side. If you are using any custom client, you could add protection or you can request owner to add protection in their clients. I can check color codes, and see if I can do anything to still send packet as a TALKMODE_SAY but ignore the color codes and use wopcolor that defined in messages.scp.

[Jhobean]

I think bug occur only on official OSI client.
Orion have an embeded fix for that.