Add some item props functionnality#1131
Merged
cbnolok merged 24 commits intoSphereserver:masterfrom Mar 14, 2024
Merged
Conversation
Member
|
2)Take a look at the Spell_Area method, anyway this area damage properties should call onTakeDamage, don't make a new method onTakeDamageArea |
5caa2cf to
53f60e9
Compare
Contributor
Author
Contributor
Author
|
@drk84 I don't figure how avoid a new method for Takedamagearea... Yes I use takeDamage on the new method. What you think of this commit? |
Contributor
|
Did you figure out the last prop you were working on? Is it still a draft? |
Contributor
Author
Ready to merge. I fixed the "criminal act check" |
cbnolok
reviewed
Nov 17, 2023
Contributor
|
Could you please fix the conflicts, in order to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I have 3 bug on this version.
1- (EDIT: FIXED)
Line
(pCharTarg->GetPropNum(pCCPChar, PROPCH_REFLECTPHYSICALDAM, pBaseCCPChar))always return 0... I set REFLECTPHYSICALDAM on target but dont know why always 0
2- (EDIT: I added LOS and range 5 to 10 depending of ERA)
is the damage area function. I copy pasted from 56d but after testing it it's just fucking non sense.
I hit everyone on the BIG screen including NPC,PET inside or outside house lol
3- (EDIT: I choose 3 type of damage link to physical)
How I can use only physical damage on iDmg ?