Fix dropping items to container with tdata3/4

[mtwango]

This should fix part 2 of #793. Items got always 1,1 position when dropping onto container and condition checking the localtion wasn't run (sice dropping would give -1,-1 and was rewritten).

Part one (item clip) should be fixed by definining container size with tdata3/4 in scripts.

Maybe move this part from code to scripts and deprecate gettings these values with some fallback in future to 0,0,512,512 (as it is in CItemContainer::ContentAdd)?

Source-X/src/game/items/CItemContainer.cpp

Line 373 in 0911dd2

{ GUMP_SCROLL, 30, 30, 270, 170 },

[cbnolok]

What about having a fallback to the default hardcoded values, in case tdata isn't defined? With a warning message in console, of course

[mtwango]

Sure, could be that way.

I was thinking about new method CEventLog::EventDeprecated with some yellowish color. It would print to the console, that this behaviour is deprecated and an alternative can be found in some place (another method, script, variable, etc.). We could pass some date or version, when it will be removed from source (and replaced with some fallback with error instead of deprecation).

But I would say that it shouldn't be part of this PR as it is beyond fixing #793.

[cbnolok]

Yes we can discuss about that new method in a separate issue. I wonder though how often would we use that

[mtwango]

I've created separate issue for the deprecation discussion: #1419 so this could be merged.

[cbnolok]

What about having a fallback to the default hardcoded values, in case tdata isn't defined? With a warning message in console, of course

Sure, could be that way.

Is this going to be part of this PR, or another one?

[mtwango]

I would leave it to diffferent one. There is warning if tdata4 is undefined / lower than tdata3.

For the undefined for both would be nice to have it in script pack, which I haven't done.