Clamp item onto container edge, when placed out of bounds#1426
Merged
cbnolok merged 2 commits intoSphereserver:devfrom May 23, 2025
Merged
Clamp item onto container edge, when placed out of bounds#1426cbnolok merged 2 commits intoSphereserver:devfrom
cbnolok merged 2 commits intoSphereserver:devfrom
Conversation
Contributor
|
Could you use lesser than 0 instead of - 1? Might be more robust |
Member
Author
|
I used -1 because it is explicitly defined in And maybe change that min/max for clamp? |
Contributor
|
Yes i thought so, but it's easy to do a fast change in other parts of the code and cause subtle bugs. |
- swap min + max to clamp
Member
Author
|
Updated both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicating client behaviour, otherwise it will just bounce to random loc in container.