Dev

.clang-tidy

@@ -1,4 +1,4 @@
-ExcludeHeaderFilterRegex: ^.*(lib\/).*
+#ExcludeHeaderFilterRegex: ^.*(lib\/).*
 
 Checks: >
   #-*,
@@ -16,33 +16,44 @@ Checks: >
   -clang-analyzer-security.insecureAPI.strcpy,
   -clang-diagnostic-format-security,
   -cppcoreguidelines-avoid-c-arrays,
+  -cppcoreguidelines-avoid-do-while,
   -cppcoreguidelines-avoid-goto,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-no-malloc,
   -cppcoreguidelines-init-variables, # false positives
   -cppcoreguidelines-owning-memory,
   -cppcoreguidelines-prefer-member-initializer,
-  -cppcoreguidelines-pro-bounds-array-pointer-decay,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  #-cppcoreguidelines-pro-bounds-array-pointer-decay,
   -cppcoreguidelines-pro-bounds-pointer-arithmetic,
   -cppcoreguidelines-pro-bounds-constant-array-index,
   -cppcoreguidelines-pro-type-const-cast,   # we have some instances, and we should remove them...
-  -cppcoreguidelines-pro-type-vararg,
+  -cppcoreguidelines-pro-type-reinterpret-cast,
   -cppcoreguidelines-pro-type-union-access,
+  -cppcoreguidelines-pro-type-vararg,
+  -cppcoreguidelines-special-member-functions, # explicit move, copy contructors...
   ##-hicpp-use-auto, #duplicate
   ##-hicpp-braces-around-statements,
   ##-hicpp-vararg, #duplicate
+  -misc-const-correctness, # temporary
   -misc-include-cleaner,
+  -misc-non-private-member-variables-in-classes,
   -modernize-avoid-c-arrays,
   -modernize-use-auto,
   -modernize-use-trailing-return-type,
   -modernize-loop-convert,
+  -modernize-macro-to-enum,
+  -modernize-use-designated-initializers,
+  -modernize-use-nodiscard,
+  -modernize-use-using,
   -readability-braces-around-statements,
   -readability-delete-null-pointer,
   -readability-else-after-return,
   -readability-function-cognitive-complexity,
   -readability-identifier-length,
   -readability-identifier-naming,
   -readability-implicit-bool-conversion,
+  -readability-inconsistent-declaration-parameter-name,
   -readability-magic-numbers,
   -readability-misleading-indentation, # to be enabled after the source is properly formatted
   -readability-simplify-boolean-expr,
@@ -52,12 +63,14 @@ Checks: >
   ##-readability-braces-around-statements,
   ##-readability-magic-numbers
 
+  #-format security
+
 # Turn all the warnings from the checks above into errors.
 #WarningsAsErrors: "*"
 
 CheckOptions:
-  - key: 'clang-analyzer-core.NonNullParamChecker:assert_like_macro'
-    value: 'DEBUG_ASSERT,ASSERT,ASSERT_ALWAYS'
+#  - key: 'clang-analyzer-core.NonNullParamChecker:assert_like_macro'
+#    value: 'DEBUG_ASSERT,ASSERT,ASSERT_ALWAYS'
   - key: 'clang-analyzer-config:noreturn_function'
     value: 'RaiseImmediateAbort,RaiseRecoverableAbort'
   - { key: readability-identifier-naming.NamespaceCase,          value: lower_case }

.clangd

@@ -17,4 +17,5 @@ CompileFlags:
 #    Diagnostics:
 #      Suppress: ['-Wunused-include-directive']
 
-# TODO: disable clazy-non-pod-global-static
+Diagnostics:
+  Suppress: non-pod-global-static

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -0,0 +1,50 @@
+name: 🐛 Bug Report
+description: Report unexpected behavior
+labels: ["bug"]
+#assignees:
+#  - cbnolok
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Before opening a bug report, please search for the behaviour in the existing issues.
+        ---
+        Thank you for taking the time to file a bug report. To address this bug as fast as possible, we need some information.
+  - type: textarea
+    id: bug-description
+    attributes:
+      label: Bug description
+      description: A clear and concise description of what the bug is.
+    validations:
+      required: true
+  - type: textarea
+    id: steps
+    attributes:
+      label: Steps to reproduce
+      description: Step-by-step guide for reproducing the bug in a vanilla SphereServer instance. If addressing a regression, please provide the sphere revision number or commit since when the bug started to occur.
+    validations:
+      required: false
+  - type: textarea
+    id: logs
+    attributes:
+      label: Expected behavior
+      description: A clear and concise description of what you expected to happen.
+    validations:
+      required: false
+  - type: input
+    id: sphere-rev
+    attributes:
+      label: Revision Number and Git Version Hash
+      placeholder: "e.g. 4031 bbfc587bb2c270c53ecb54cb5e1ea2f54cd9031f"
+    validations:
+      required: true
+   - type: dropdown
+     id: sphere-branch
+    attributes:
+       label: Branch
+       description: "Select the branch you are working with"
+       options:
+          - "master"
+          - "dev"
+      validations:
+        required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,14 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Support & Discussions & More
+    url: https://discord.gg/ZrMTXrs
+    about: ''
+  - name: Documentation (Wiki)
+    url: https://wiki.spherecommunity.net/
+    about: ''
+  - name: Changelogs (Master branch)
+    url: https://github.com/Sphereserver/Source-X/blob/master/Changelog.txt
+    about: ''
+  - name: Changelogs (Dev branch)
+    url: https://github.com/Sphereserver/Source-X/blob/dev/Changelog.txt
+    about: ''

.github/ISSUE_TEMPLATE/feature-request.md

@@ -0,0 +1,14 @@
+---
+name: "\U0001F4A1 Feature Request"
+about: Suggest an idea.
+title: ''
+labels: feature
+#assignees: cbnolok
+
+---
+
+#### Description
+<!-- Description of the feature -->
+
+#### Why this should be added
+<!-- Give a use case for this feature -->

.github/workflows/build_aux_files.yml

@@ -15,10 +15,14 @@ jobs:
     # Upload artifact linked to GitHub RELEASE we are creating - only if the run is for a pull request, or for selected branches
     #if: contains(fromJson('["master", "main"]'), github.ref_name)
 
+    permissions:
+      contents: write
+      actions: write
+
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           fetch-depth: 0
 

.github/workflows/build_linux_x86.yml

@@ -23,11 +23,14 @@ on:
 
 jobs:
   linux-x86:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
+    permissions:
+      contents: read
+      actions: read
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
       with:
         fetch-depth: 0
     - name: Install prerequisites
@@ -130,11 +133,14 @@ jobs:
     needs: linux-x86
     # Upload artifact linked to GitHub RELEASE we are creating - only if the run is for a pull request, or for selected branches
     if: contains(fromJson('["master", "main"]'), github.ref_name)
+    permissions:
+      contents: read
+      actions: write
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-linux-x86
           merge-multiple: true
@@ -153,11 +159,14 @@ jobs:
   upload_selfhost_release:
     needs: linux-x86
     if: contains(fromJson('["master", "main"]'), github.ref_name) && (github.repository == 'SphereServer/Source-X')
+    permissions:
+      contents: read
+      actions: write
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-linux-x86
           merge-multiple: true

.github/workflows/build_linux_x86_64.yml

@@ -20,11 +20,14 @@ on:
 
 jobs:
   linux-x86_64:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
+    permissions:
+      contents: read
+      actions: read
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
       with:
         fetch-depth: 0
     - name: Install prerequisites
@@ -85,11 +88,14 @@ jobs:
     needs: linux-x86_64
     # Upload artifact linked to GitHub RELEASE we are creating - only if the run is for a pull request, or for selected branches
     if: contains(fromJson('["master", "main"]'), github.ref_name)
+    permissions:
+      contents: read
+      actions: write
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-linux-x86_64
           merge-multiple: true
@@ -107,11 +113,14 @@ jobs:
   upload_selfhost_release:
     needs: linux-x86_64
     if: contains(fromJson('["master", "main"]'), github.ref_name) && (github.repository == 'SphereServer/Source-X')
+    permissions:
+      contents: read
+      actions: write
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-linux-x86_64
           merge-multiple: true

.github/workflows/build_osx_arm.yml

@@ -20,15 +20,19 @@ on:
 
 jobs:
   macos-arm64:
-    runs-on: macos-14   # apple silicon
+    runs-on: macos-15   # apple silicon
+    permissions:
+      contents: read
+      actions: read
+
     env:
       CMAKE_GEN: Ninja
       #CMAKE_TCH: cmake/toolchains/OSX-AppleClang-native.cmake
       CMAKE_TCH: cmake/toolchains/OSX-AppleClang-AArch64.cmake
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
       with:
         fetch-depth: 0
     - name: Install prerequisites
@@ -72,14 +76,16 @@ jobs:
 
 
   upload_github_release:
-    needs: macos-arm64
-    # Upload artifact linked to GitHub RELEASE we are creating - only if the run is for a pull request, or for selected branches
+    needs: macos-arm64   # Upload artifact linked to GitHub RELEASE we are creating - only if the run is for a pull request, or for selected branches
     if: contains(fromJson('["master", "main"]'), github.ref_name)
+    permissions:
+      contents: read
+      actions: write
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-osx-arm64
           merge-multiple: true
@@ -98,11 +104,14 @@ jobs:
   upload_selfhost_release:
     needs: macos-arm64
     if: contains(fromJson('["master", "main"]'), github.ref_name) && (github.repository == 'SphereServer/Source-X')
+    permissions:
+      contents: read
+      actions: write
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-osx-arm64
           merge-multiple: true

.github/workflows/build_osx_x86_64.yml

@@ -20,14 +20,18 @@ on:
 
 jobs:
   macos-x86_64:
-    runs-on: macos-13   # intel
+    runs-on: macos-15-intel
+    permissions:
+      contents: read
+      actions: read
+
     env:
       CMAKE_GEN: Ninja
       CMAKE_TCH: cmake/toolchains/OSX-AppleClang-x86_64.cmake
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
       with:
         fetch-depth: 0
     - name: Install prerequisites
@@ -70,13 +74,17 @@ jobs:
 
   upload_github_release:
     needs: macos-x86_64
+    permissions:
+      contents: read
+      actions: write
+
     # Upload artifact linked to GitHub RELEASE we are creating - only if the run is for a pull request, or for selected branches
     if: contains(fromJson('["master", "main"]'), github.ref_name)
 
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-osx-x86_64
           merge-multiple: true
@@ -99,7 +107,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download builds
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           name: Build-osx-x86_64
           merge-multiple: true