Windows build Login BUG

[Jhobean]

I have an intermitent bug. Some account seem to be ban for the server... After connecting, the server kick the user out.... If user use an other account, all work well.

This degub screen can help?

Bug occur with 2 Clients Orion and cross UO

[coruja747]

Try using an previous build to check what's the last build working (eg: build 123 = working fine, build 124 = error). With this info we would know exactly what changes caused the error, making it easier to fix

Here you can find all recent builds to download, just click on the build, select Visual Studio (windows build), click on Artifacts page and download the zip
https://ci.appveyor.com/project/coruja747/source/history

[Jhobean]

It's an intermittent bug so it's really difficult to test. I'll let you know if I found a patern.

This line and this code may help?
CRITICAL:"Access Violation" (0x1351c8), in NetworkInput::ProcessNewClient() #1

on the other Issues his code is 0x1541c6

[Jhobean]

At this time, this build FAIL : 0.56.4.895
Now testing 0.56.4.894

[Jhobean]

At this time, Bug seem between 94 and 95 . I'll run this version few day before confirmation.

[Jhobean]

@coruja747 I confirm the bug seem to provide from this commit:
ee1bf26

[Jhobean]

Make a hold. Just had the bug with build 94 again.....

[Nirad]

@coruja747 I can't find the problem of this bug .. #193 #196

[coruja747]

Try using this test build https://ci.appveyor.com/api/buildjobs/6ji2yqat3xcu7r8v/artifacts/SphereSvr-Win32-Test.zip

It's the latest 56d build with just an extra debug message to track this error, so when you get this error again just copy/paste it here

[Jhobean]

Ok thx. Let me few days

[FiLoUs64]

Got this after a login with your test build.

08:25:DEBUG:__ thread (1696) __ | # | _____________ function _____________ | __ ticks passed from previous function start __
08:25:DEBUG:>> 1696 | 0 | NetworkManager::tick | +0
08:25:DEBUG:>> 1696 | 1 | NetworkThread::tick | +0
08:25:DEBUG:>> 1696 | 2 | NetworkInput::processInput | +0
08:25:DEBUG:>> 1696 | 3 | NetworkInput::processData | +0
08:25:DEBUG:>> 1696 | 4 | NetworkInput::processData | +0
08:25:DEBUG:>> 1696 | 5 | NetworkInput::processUnknownClientData | +0
08:25:DEBUG:>> 1696 | 6 | CClient::xProcessClientSetup | +0
08:25:DEBUG:>> 1696 | 7 | CClient::Login_ServerList | +0
08:25:DEBUG:>> 1696 | 8 | CClient::LogIn | +0
08:25:DEBUG:>> 1696 | 9 | CClient::LogIn2 | +0 <-- exception catch point (below is guessed and could be incorrect!)
08:25:CRITICAL:"Access Violation" (0xfb9e6), in CClient::Account login() #2 "Check in use"
08:25:DEBUG:__ thread (1696) __ | # | _____________ function _____________ | __ ticks passed from previous function start __
08:25:DEBUG:>> 1696 | 0 | NetworkManager::tick | +0
08:25:DEBUG:>> 1696 | 1 | NetworkThread::tick | +0
08:25:DEBUG:>> 1696 | 2 | NetworkInput::processInput | +0
08:25:DEBUG:>> 1696 | 3 | NetworkInput::processData | +0
08:25:DEBUG:>> 1696 | 4 | NetworkInput::processData | +0
08:25:DEBUG:>> 1696 | 5 | NetworkInput::processGameClientData | +0
08:25:DEBUG:>> 1696 | 6 | PacketServerSelect::onReceive | +0
08:25:DEBUG:>> 1696 | 7 | CClient::Login_Relay | +0
08:25:DEBUG:>> 1696 | 8 | CClient::addRelay | +0 <-- exception catch point (below is guessed and could be incorrect!)
08:25:CRITICAL:"Access Violation" (0x93895), in CClient::addRelay() #1 "customer id"
08:25:DEBUG:account ''

Thanks

[coruja747]

The problem seems to be when server check if the account is already in use, I added more specific debug messages to track this, try using this new build and check the console error again
https://ci.appveyor.com/api/buildjobs/ca9e3kb6b3ywpffg/artifacts/SphereSvr-Win32-Test.zip

[Nirad]

Thx we will give a try !
and feedback after

[FiLoUs64]

Not been able to reproduce the issue BUT I have a lot a problem for login, always have a message like what the account is already in use after logout.

[Nirad]

This can help ?