Skip to content

Fix weekly link checker: remove deprecated --exclude-mail#2

Merged
Spider333 merged 1 commit into
mainfrom
fix/link-checker-exclude-mail
Mar 16, 2026
Merged

Fix weekly link checker: remove deprecated --exclude-mail#2
Spider333 merged 1 commit into
mainfrom
fix/link-checker-exclude-mail

Conversation

@Spider333
Copy link
Copy Markdown
Owner

@Spider333 Spider333 commented Mar 16, 2026

Summary

  • Removed --exclude-mail flag from lychee args — it was removed in lychee v0.23.0 (mail exclusion is now the default behavior)
  • This was the root cause of the workflow failing in 5 seconds with 4 annotations

Test plan

  • Merge and trigger workflow manually (workflow_dispatch) to confirm it passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated link checking configuration to validate mail links during automated checks.

lychee v0.23.0 removed --exclude-mail (mail exclusion is now default).
This was causing the workflow to crash on startup.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

PR Auto-Review

Looks good! No guardrail violations detected. A maintainer will review this shortly.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4a78b1c2-8a8e-4bea-bd20-b2d438b6e52b

📥 Commits

Reviewing files that changed from the base of the PR and between aa83239 and e6d1855.

📒 Files selected for processing (1)
  • .github/workflows/link-checker.yml

📝 Walkthrough

Walkthrough

The --exclude-mail argument was removed from the Lychee link checker invocation in a GitHub Actions workflow, modifying how the link checker processes email-related content during automated checks.

Changes

Cohort / File(s) Summary
Link Checker Configuration
.github/workflows/link-checker.yml
Removed the --exclude-mail argument from the Lychee link checker command invocation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A checkmark bounces, mail finds its way,
No more exclusions block the day,
Links dance freely, east and west,
The workflow runs its very best! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the deprecated --exclude-mail flag from the link checker workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/link-checker-exclude-mail
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@github-actions
Copy link
Copy Markdown

PR Auto-Review

Looks good! No guardrail violations detected. A maintainer will review this shortly.

@Spider333 Spider333 merged commit 39ed772 into main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant