Skip to content

Fix GITHUB_OUTPUT format error in link checker#3

Merged
Spider333 merged 1 commit into
mainfrom
fix/link-checker-output-format
Mar 16, 2026
Merged

Fix GITHUB_OUTPUT format error in link checker#3
Spider333 merged 1 commit into
mainfrom
fix/link-checker-output-format

Conversation

@Spider333
Copy link
Copy Markdown
Owner

@Spider333 Spider333 commented Mar 16, 2026

Summary

  • Fixed grep -c with || echo "0" corrupting $GITHUB_OUTPUT by writing a bare 0 on a separate line
  • Also cleaned up stray blank line from previous fix

Test plan

  • Merge and trigger workflow manually to confirm full green run

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enhanced the automated link checking workflow with improved error handling and variable initialization.
    • Removed URL exclusions to perform more comprehensive link validation checks.
    • Improved error counting logic to ensure reliable detection of broken links.
    • Ensured consistent output reporting throughout the CI/CD process.

grep -c returns exit 1 on no matches, causing `|| echo "0"` to append
a bare "0" line to GITHUB_OUTPUT. Use `|| true` instead and default
BROKEN to 0.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

PR Auto-Review

Looks good! No guardrail violations detected. A maintainer will review this shortly.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 66296142-e97e-455e-a0dc-e339fd6c0ef8

📥 Commits

Reviewing files that changed from the base of the PR and between 39ed772 and 710fe3b.

📒 Files selected for processing (1)
  • .github/workflows/link-checker.yml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow configuration for link checking was updated to remove exclusions, reinitialize error variables, improve error counting logic with fallback handling, and ensure broken link counts are always written to output.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/link-checker.yml
Removed exclusions (tornadocash.eth.link, localhost, 127.0.0.1) and README.md from link check targets. Initialized BROKEN variable to 0, updated error counting with improved grep fallback logic, and added guard to ensure broken_count is always written to GitHub output even when out.md is missing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A workflow refined with a hop and a bound,
No broken links left unchecked or unround,
Exclusions removed with a swift gentle swipe,
Output flows steady, no matter the hype! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary change: fixing a GITHUB_OUTPUT format error in the link checker workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/link-checker-output-format
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Migrating from UI to YAML configuration.

Use the @coderabbitai configuration command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.

@github-actions
Copy link
Copy Markdown

PR Auto-Review

Looks good! No guardrail violations detected. A maintainer will review this shortly.

@Spider333 Spider333 merged commit e7d72cb into main Mar 16, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant