Improvement to compute sparsity without WaveformsExtractor #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgarcia
added
enhancement
Member
Author
|
@yger @h-mayorquin @alejoe91 : ready to review |
Collaborator
|
If we along these lines, then I would also be tempted to modify all the function in templates_tools.py to also have an extended signature with templates_or_waveform_extractor instead of simply waveform_extractor. What do you think ? Can I do that? This would be usefull for playing with templates in the hybrid case, i.e. sorting them by amplitudes, slicing them, ... |
alejoe91
reviewed
Jan 23, 2024
alejoe91
reviewed
Jan 23, 2024
zm711
reviewed
Jan 23, 2024
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
A few docstring fixes and an assert tweak.
Collaborator
|
I will built my PR on this one, but don't you think that estimate_templates() should return a Templates object ? I mean, we should enforce such object everywhere, no? |
yger
approved these changes
Jan 26, 2024
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
alejoe91
reviewed
Jan 29, 2024
alejoe91
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
WaveformExtractor(as before) andTemplatesobjectsestimate_templates()which is fast and do not needWaveformExtractorrandom_spikes_selection()estimate_sparsity()function. This is also fast. This could replaceprecompute_sparsity()This will be used bySortingResultThis PR do not break any signature or behavior. Just improve or enhance previous functions.