Skip to content

Conversation

@alejoe91
Copy link
Member

@alejoe91 alejoe91 commented Jun 7, 2024

@samuelgarcia

I would merge this (#2827) first and release 0.100.7 bug fixes.

then this is ready to follow!

@zm711
Copy link
Member

zm711 commented Jun 7, 2024

Like Heberto I don't fully understand the DEV flag? So in this type of release would the dev be False? Or you don't need to change that?

@alejoe91
Copy link
Member Author

alejoe91 commented Jun 7, 2024

@samuelgarcia this is an edge case, what do you think?

@zm711
Copy link
Member

zm711 commented Jun 7, 2024

Also super tiny, but if we decide to do some sort of automated changelog in the future this is 0.101.0rc0, no? In the title of the PR :)

@samuelgarcia
Copy link
Member

The DEV must be False in pypi release. It tell the code that for sure the install not in editable mode and then for installing SI inside conatiners then we use the pypi.
When DEV=True then can copy the sources inside the dockers.

So yes DEV=False for every release and then True just after.

alejoe91 and others added 2 commits June 7, 2024 17:43
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
@alejoe91 alejoe91 changed the title Updated release notes and pyproject for 0.100.0rc0 Updated release notes and pyproject for 0.101.0rc0 Jun 7, 2024
@alejoe91
Copy link
Member Author

alejoe91 commented Jun 8, 2024

@samuelgarcia DEV=False is merged. Can someone approve this so we cut the pre-release for @DradeAW ?

@zm711 @h-mayorquin

@alejoe91
Copy link
Member Author

alejoe91 commented Jun 8, 2024

Thanks guys!

@alejoe91 alejoe91 merged commit 8647e15 into SpikeInterface:main Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants