Fixes Issue4180 #4247
Merged
Fixes Issue4180 #4247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2025 10:30
The UnsignedToSignedRecording class was missing the bit_depth parameter in its _kwargs dictionary, causing it to be lost during clone operations. This resulted in incorrect trace values when set_probe() was called on unsigned-to-signed recordings with custom bit depths. Fixes SpikeInterface#4180
samuelgarcia
approved these changes
Dec 8, 2025
Member
|
merci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4180
preserve bit_depth parameter in UnsignedToSignedRecording serialization
The UnsignedToSignedRecording class was missing the bit_depth parameter
in its _kwargs dictionary, causing it to be lost during clone operations.
This resulted in incorrect trace values when set_probe() was called on
unsigned-to-signed recordings with custom bit depths.
I think that doesn't affect anything else but I'm quite new to spikeinterface