Update Jekyll, comment-out embed-code commands#359
Update Jekyll, comment-out embed-code commands#359alexander-yevsyukov merged 3 commits intomasterfrom
embed-code commands#359Conversation
... until the Jekyll bug with leakage of subcommands into the page content is fixed.
... until the Jekyll bug with leakage of subcommands into the page content is fixed.
|
@oleksandra-kovalenko, please find the issue with Jekyll or GitHub Pages which caused the problem which this PR addressed. If there is no such issue, please create it and link it to this PR. |
embed-code commands
embed-code commandsembed-code commands
|
This Jekyll issue relates to support of Kramdown v2 syntax. The description of the issue mentions “invisible errors” that may occur to GitHub Pages users because if Pages migrate to Jekyll v4. I suspect, we're dealing with one of such “invisible” issues... |
|
Here are the details on the Jekyll 3.9.0 release. |
|
Here's the link to Kramdown news. The post for v2 says it has breaking changes. @armiol, FYI. |
|
The version 2.3.0 of Kramdown introduces the following breaking change (quote from the news): Here's the link to the issue. |
|
The Kramdown issue which affects us is already closed. |
This PR fixes the Jekyll problem with leakage of the
embed-codeinstructions into the content of the pages.It was discovered when visiting https://spine.io. The problem manifested in both Quick Start and Integration guides.
The Jekyll version was updated to 3.9.0 to reproduce the bug locally. It did not manifest itself with the previous version.
Since GitHub renders the site itself using Jekyll (we do not submit the
_sitedirectory to version control), most likely they updated Jekyll recently. That's why we observe the problem when the site is published.embed-codeinstructions were commented out, not removed. They need to be restored after the Jekyll / GitHub Pages issue is fixed.