Skip to content

Update Jekyll, comment-out embed-code commands#359

Merged
alexander-yevsyukov merged 3 commits intomasterfrom
update-jekyll
Aug 7, 2020
Merged

Update Jekyll, comment-out embed-code commands#359
alexander-yevsyukov merged 3 commits intomasterfrom
update-jekyll

Conversation

@alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Aug 7, 2020

This PR fixes the Jekyll problem with leakage of the embed-code instructions into the content of the pages.
It was discovered when visiting https://spine.io. The problem manifested in both Quick Start and Integration guides.

The Jekyll version was updated to 3.9.0 to reproduce the bug locally. It did not manifest itself with the previous version.

Since GitHub renders the site itself using Jekyll (we do not submit the _site directory to version control), most likely they updated Jekyll recently. That's why we observe the problem when the site is published.

embed-code instructions were commented out, not removed. They need to be restored after the Jekyll / GitHub Pages issue is fixed.

... until the Jekyll bug with leakage of subcommands into the page content is fixed.
... until the Jekyll bug with leakage of subcommands into the page content is fixed.
@alexander-yevsyukov alexander-yevsyukov self-assigned this Aug 7, 2020
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review August 7, 2020 17:05
@alexander-yevsyukov alexander-yevsyukov merged commit db23315 into master Aug 7, 2020
@alexander-yevsyukov
Copy link
Contributor Author

@oleksandra-kovalenko, please find the issue with Jekyll or GitHub Pages which caused the problem which this PR addressed.

If there is no such issue, please create it and link it to this PR.

@alexander-yevsyukov alexander-yevsyukov changed the title Update Jekyll and other dependencies Update Jekyll and other dependencies, comment-out embed-code commands Aug 7, 2020
@alexander-yevsyukov alexander-yevsyukov changed the title Update Jekyll and other dependencies, comment-out embed-code commands Update Jekyll, comment-out embed-code commands Aug 7, 2020
@alexander-yevsyukov
Copy link
Contributor Author

This Jekyll issue relates to support of Kramdown v2 syntax. The description of the issue mentions “invisible errors” that may occur to GitHub Pages users because if Pages migrate to Jekyll v4.

I suspect, we're dealing with one of such “invisible” issues...

@alexander-yevsyukov
Copy link
Contributor Author

Here are the details on the Jekyll 3.9.0 release.

@alexander-yevsyukov
Copy link
Contributor Author

Here's the link to Kramdown news. The post for v2 says it has breaking changes.

@armiol, FYI.

@alexander-yevsyukov
Copy link
Contributor Author

The version 2.3.0 of Kramdown introduces the following breaking change (quote from the news):

Although this is a minor version bump there is one breaking change: Parsing of XML processing instructions was removed because they are invalid for HTML5 documents.

Here's the link to the issue.

@alexander-yevsyukov alexander-yevsyukov deleted the update-jekyll branch August 14, 2020 09:30
@alexander-yevsyukov
Copy link
Contributor Author

The Kramdown issue which affects us is already closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants