Skip to content

Define Language members#522

Merged
alexander-yevsyukov merged 6 commits intomasterfrom
we-speak-no-americano
Apr 2, 2020
Merged

Define Language members#522
alexander-yevsyukov merged 6 commits intomasterfrom
we-speak-no-americano

Conversation

@alexander-yevsyukov
Copy link
Contributor

This PR adds members of the Language type (thus addressing #2).

@alexander-yevsyukov alexander-yevsyukov self-assigned this Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #522 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #522   +/-   ##
=========================================
  Coverage     73.90%   73.90%           
  Complexity     2912     2912           
=========================================
  Files           500      500           
  Lines         11747    11747           
  Branches        658      658           
=========================================
  Hits           8682     8682           
  Misses         2841     2841           
  Partials        224      224           

Copy link
Collaborator

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov LGTM with a few comments to address.

cy = 177;
// Western Frisian
fy = 178;
// Wolof
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the spacing.

yi = 181;
// Yoruba
yo = 182;
// Zhuang, Chuang
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

xh = 180;
// Yiddish
yi = 181;
// Yoruba
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

@alexander-yevsyukov alexander-yevsyukov merged commit e512b37 into master Apr 2, 2020
@alexander-yevsyukov alexander-yevsyukov deleted the we-speak-no-americano branch April 2, 2020 13:05
@dmitrykuzmin dmitrykuzmin mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants