Allow (is) & (every_is) simultaneously#531
Merged
dmdashenkov merged 7 commits intomasterfrom Apr 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
============================================
- Coverage 73.70% 73.70% -0.01%
+ Complexity 2931 2930 -1
============================================
Files 503 503
Lines 11872 11871 -1
Branches 668 667 -1
============================================
- Hits 8750 8749 -1
Misses 2902 2902
Partials 220 220 |
Contributor
Author
|
@armiol, PTAL. |
armiol
reviewed
Apr 27, 2020
Collaborator
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov do we test this behavior?
armiol
approved these changes
Apr 27, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider options
(is)and(every_is)applied to a type at the same time:Currently, Java class
Tomatoonly implementsVegetableinterface.With this PR we make
(is)and(every_is)complementary. This way, Java classTomatoimplements bothVegetableandFruitinterfaces.