Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
============================================
- Coverage 73.79% 73.78% -0.02%
+ Complexity 2953 2949 -4
============================================
Files 506 505 -1
Lines 11954 11940 -14
Branches 669 668 -1
============================================
- Hits 8822 8810 -12
+ Misses 2904 2903 -1
+ Partials 228 227 -1 |
dmdashenkov
requested review from
alexander-yevsyukov and
armiol
and removed request for
armiol
Contributor
Author
|
@alexander-yevsyukov, PTAL. @armiol, PTAL. @serhii-lekariev, FYI. |
armiol
reviewed
Jun 8, 2020
Collaborator
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov please see my comment. Let's discuss tomorrow in person.
| */ | ||
| @Override | ||
| protected boolean enabled() { | ||
| public boolean enabled() { |
Collaborator
There was a problem hiding this comment.
This was a design purpose to prohibit invoking this method from outside the package. This is why they were not enums.
Contributor
|
@armiol, @alexander-yevsyukov, FYI. As discussed with @dmdashenkov, I'll tweak the design of |
Contributor
Author
|
@serhii-lekariev, I'll close the PR but leave the branch alive for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a recent PR, we've been observing a number of code style warnings from ErrorProne. This PR resolves those warnings.