Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
=========================================
Coverage 73.98% 73.99%
- Complexity 2969 2975 +6
=========================================
Files 506 506
Lines 11990 12001 +11
Branches 671 674 +3
=========================================
+ Hits 8871 8880 +9
+ Misses 2892 2891 -1
- Partials 227 230 +3 |
Contributor
Author
|
@armiol, PTAL. |
armiol
approved these changes
Aug 27, 2020
Collaborator
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov LGTM. However, please respect #561 in this changeset as well. We need those structural changes for the publishing procedure.
# Conflicts: # version.gradle.kts
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from now, we will check that
(min),(max), and(range)constraints on whole numbers (int32, etc.) are themselves whole numbers.Also, some leftover debug output is trimmed.