Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
============================================
- Coverage 73.99% 73.98% -0.01%
- Complexity 2975 2977 +2
============================================
Files 506 506
Lines 12001 12008 +7
Branches 674 673 -1
============================================
+ Hits 8880 8884 +4
- Misses 2891 2894 +3
Partials 230 230 |
Contributor
Author
|
@dmitrykuzmin, PTAL. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we make the Gradle tasks declared by Model Compiler have more strict bounds to the task graph.
Previously, some tasks were only bound from one side, i.e. a task must have been executed after an existing one. This is insufficient, since, in some cases, such tasks might be moved in the task graph in such a way that their result it not captured by another task. For example, the task which generates a descriptor reference file (
desc.ref) could've been executed afterprocessResources, which would lead to thedesc.reffile missing from the classpath at runtime.In this PR we add more constraints to make sure that the tasks are ordered properly.