Skip to content

Gradle task ordering#562

Merged
dmdashenkov merged 7 commits intomasterfrom
gradle-task-ordering
Sep 1, 2020
Merged

Gradle task ordering#562
dmdashenkov merged 7 commits intomasterfrom
gradle-task-ordering

Conversation

@dmdashenkov
Copy link
Contributor

@dmdashenkov dmdashenkov commented Sep 1, 2020

In this PR we make the Gradle tasks declared by Model Compiler have more strict bounds to the task graph.

Previously, some tasks were only bound from one side, i.e. a task must have been executed after an existing one. This is insufficient, since, in some cases, such tasks might be moved in the task graph in such a way that their result it not captured by another task. For example, the task which generates a descriptor reference file (desc.ref) could've been executed after processResources, which would lead to the desc.ref file missing from the classpath at runtime.

In this PR we add more constraints to make sure that the tasks are ordered properly.

@dmdashenkov dmdashenkov self-assigned this Sep 1, 2020
@dmdashenkov dmdashenkov linked an issue Sep 1, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #562 into master will decrease coverage by 0.00%.
The diff coverage is 17.39%.

@@             Coverage Diff              @@
##             master     #562      +/-   ##
============================================
- Coverage     73.99%   73.98%   -0.01%     
- Complexity     2975     2977       +2     
============================================
  Files           506      506              
  Lines         12001    12008       +7     
  Branches        674      673       -1     
============================================
+ Hits           8880     8884       +4     
- Misses         2891     2894       +3     
  Partials        230      230              

@dmdashenkov dmdashenkov marked this pull request as ready for review September 1, 2020 11:37
@dmdashenkov
Copy link
Contributor Author

@dmitrykuzmin, PTAL.

Copy link
Contributor

@dmitrykuzmin dmitrykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmdashenkov dmdashenkov merged commit 01e059b into master Sep 1, 2020
@dmdashenkov dmdashenkov deleted the gradle-task-ordering branch September 1, 2020 11:47
@dmitrykuzmin dmitrykuzmin mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gradle task ordering constraints

2 participants