More dependency automation and IDEA configuration#65
Merged
dmdashenkov merged 9 commits intomasterfrom Sep 3, 2020
Merged
Conversation
Contributor
Author
|
@alexander-yevsyukov, PTAL. |
alexander-yevsyukov
requested changes
Sep 3, 2020
Contributor
alexander-yevsyukov
left a comment
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my comment.
| @@ -80,6 +84,8 @@ private static ArtifactSnapshot load() { | |||
| .setSpineCoreVersion(properties.getProperty("spine.version.core")) | |||
Contributor
There was a problem hiding this comment.
Please see if we can have a class which declares these constants and used at both ends.
If it's not easy, please document usage of this constants at both ends: when they generated, and here (consumed), referring to the other end of this trick.
Contributor
Author
|
@alexander-yevsyukov, PTAL again. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add some more automation features to the plugin.
Library dependencies
Now, in order to add a Spine library dependency, the user can use API provided by the plugin, instead of specifying artifacts manually. This includes:
spine.enableJava { withDatastore() }IDEA configuration
If both Bootstrap and the
ideaplugin are applied, Bootstrap configures theideaplugin, so that the IDE displays sources and generated sources as expected.