Update config and Gradle. Add missing Readme instructions#22
Merged
yuri-sergiichuk merged 11 commits intomasterfrom Dec 10, 2020
Merged
Update config and Gradle. Add missing Readme instructions#22yuri-sergiichuk merged 11 commits intomasterfrom
config and Gradle. Add missing Readme instructions#22yuri-sergiichuk merged 11 commits intomasterfrom
Conversation
…e `PubCache` implementation in `base`.
Contributor
Author
|
@dmdashenkov PTAL. The build is failing because the |
dmdashenkov
approved these changes
Dec 10, 2020
Contributor
dmdashenkov
left a comment
dmdashenkov
left a comment
There was a problem hiding this comment.
LGTM with a minor comment.
| ```bash | ||
| pub global activate protoc_plugin | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Please kill this emply line.
The presence of the `PUB_CACHE` env is not a required condition while we may wanna try to rely on the default installation paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have updated the
configsub-module to reference the latest changes. Also, I updated the Gradle to the latest v6.7.1 and added the missing instructions part to theREADME.As part of the PR I fixed issues related to using Dart SDK bundled in the Flutter distribution, we're now able to configure the
PUB_CACHEvariable in the very same way thePubCacheis configured for the Dart proto plugin.I have also updated the
baseandwebversions and fixed related deprecations.The issue is also related to the parent Gradle deps management issue SpineEventEngine/config#156.