Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
============================================
+ Coverage 94% 94.45% +0.45%
- Complexity 523 533 +10
============================================
Files 66 67 +1
Lines 1918 1931 +13
Branches 107 103 -4
============================================
+ Hits 1803 1824 +21
+ Misses 78 74 -4
+ Partials 37 33 -4 |
Contributor
Author
|
@armiol, PTAL. |
armiol
approved these changes
Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce an API for thread-safe Datastore transactions.
Previously, transactions were handled by
DatastoreWrapper. When required, the wrapper substituted theDatastorefor a transaction and executed all the requests upon that transaction.This approach caused concurrency issues.
Now that API is deprecated. It should be removed in subsequent releases.
The new API for transactions allows managing a single Datastore transaction independently of all the others.