Merged
Conversation
armiol
approved these changes
Jun 24, 2020
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@yuri-sergiichuk LGTM with a comment to address before merging.
| @@ -0,0 +1,66 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
I am not sure why this file is called pubsub_push.proto. pubsub is present in both package name and library names.
push.proto is enough.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have added a new
pubsubmodule with a reusablePubsubPushRequestwrapper around the Pub/Sub push requests.The reasoning for such a proto is that we've already created and recreated that same functionality internally 3 or 4 times and it doesn't look like the respective proto definition may appear in the official repo any time soon.
The defined proto could be used for endpoints that are used with Pub/Sub Push subscriptions in order to easily transform incoming JSON data into a respective Protobuf definition.