[1.x] Implement new shard pick-up API introduced by core-java.#181
Merged
[1.x] Implement new shard pick-up API introduced by core-java.#181
core-java.#181Conversation
Author
|
@armiol PTAL. |
armiol
approved these changes
Apr 19, 2023
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
LGTM with a comment to address.
|
|
||
| @Test | ||
| @DisplayName("complete the shard session (once picked up) and make it available for picking up") | ||
| void completeSessionAndMakeItAvailable() { |
Contributor
There was a problem hiding this comment.
We don't "complete" now. Please update the naming here and in the display name.
ndolhii
changed the title
core-java.core-java.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR a new API introduced in the #1505 is implemented for Datastore-based Work Registry.
Breaking Change
From now on the
method in
DsShardedWorkRegistrywill throw aDatastoreExceptionindicating either a technical problem communicating with Datastore, or a concurrent change of a stored session.