Simplify filtering by enum columns#127
Merged
dmitrykuzmin merged 4 commits intomasterfrom Dec 17, 2019
Merged
Conversation
The Spine version updates to `1.2.10`, `base` dependency updates to `1.2.4`.
Contributor
Author
|
@armiol PTAL. The build depends on base#501 and core-java#1215. |
Contributor
Author
|
@dmdashenkov PTAL. |
dmdashenkov
approved these changes
Dec 17, 2019
Contributor
dmdashenkov
left a comment
There was a problem hiding this comment.
LGTM as soon as the build passes.
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
============================================
- Coverage 61.11% 60.83% -0.29%
Complexity 172 172
============================================
Files 86 86
Lines 2083 2096 +13
Branches 36 37 +1
============================================
+ Hits 1273 1275 +2
- Misses 800 811 +11
Partials 10 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the process of creation of the enum column filters.
It's currently required for all enum column values to be wrapped as Protobuf
EnumValuebefore being passed to the filter, to enable the correct processing on the server side.Previously, creating such a filter required verbose and hacky code on the client side.
This PR extends the client API so now such filter can be created as follows:
Spine version advances to
1.2.10.