Keep up/cancel subscription requests fix.#154
Merged
YegorUdovchenko merged 10 commits intomasterfrom Oct 22, 2020
Merged
Conversation
YegorUdovchenko
changed the title
YegorUdovchenko
added
the
Client JS
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
============================================
+ Coverage 61.79% 61.88% +0.09%
Complexity 178 178
============================================
Files 88 88
Lines 2188 2188
Branches 40 40
============================================
+ Hits 1352 1354 +2
+ Misses 827 825 -2
Partials 9 9 |
Collaborator
Author
|
@dmitrykuzmin PTAL |
Collaborator
Author
|
@dmdashenkov PTAL |
dmdashenkov
suggested changes
Oct 19, 2020
|
|
||
| /** Interval in milliseconds for sending subscription keep up requests. */ | ||
| _keepUpInterval() { | ||
| return SUBSCRIPTION_KEEP_UP_INTERVAL.inMs(); |
Contributor
There was a problem hiding this comment.
Let's make this configurable. I think, it is configurable on the server side.
| }); | ||
|
|
||
| function subscribeToAllTasks() { | ||
| const topic = client.newTopic() |
Contributor
There was a problem hiding this comment.
This can be shortened as
return client.subscribeTo(Task).post();| } | ||
|
|
||
| /** Interval in milliseconds for sending subscription keep up requests. */ | ||
| _keepUpInterval() { |
Contributor
There was a problem hiding this comment.
If this method stays unchanged after addressing @dmdashenkov request, it should be marked @private like all others.
Collaborator
Author
|
@dmitrykuzmin @dmdashenkov PTAL again. |
dmdashenkov
approved these changes
Oct 22, 2020
dmitrykuzmin
approved these changes
Oct 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings changes enabling sending of requests for keeping up and cancelling Firebase subscriptions.
The following fixes were made:
FirebaseSubscriptionServicemaking itrun()andstop(). This service now can run and stop itself depending on presence of subscriptions it manages./subscription/keep-upand/subscription/cancelrequests are sent correctly during a subscription lifecycle.