Allow using Firebase RDB emulator with Firebase client#166
Merged
yuri-sergiichuk merged 13 commits intomasterfrom Feb 1, 2021
Merged
Allow using Firebase RDB emulator with Firebase client#166yuri-sergiichuk merged 13 commits intomasterfrom
yuri-sergiichuk merged 13 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
============================================
+ Coverage 60.14% 60.41% +0.26%
- Complexity 210 213 +3
============================================
Files 93 93
Lines 2366 2382 +16
Branches 43 45 +2
============================================
+ Hits 1423 1439 +16
Misses 932 932
Partials 11 11 |
dmdashenkov
approved these changes
Feb 1, 2021
Contributor
dmdashenkov
left a comment
There was a problem hiding this comment.
@yuri-sergiichuk, LGTM as soon as all the checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of the Firebase RDB emulator endpoint. The DB URL may be of two formats:
https://<database-alias>.firebaseio.comDB URL points to a remote Firebase RDB;http://<local-ip>:<local-port>?ns=<database-alias>points to a local Firebase RDB emulator.For the latter, the
nspart stands fornamespaceand is effectively used by the emulator as a way to determine the local database instance to be used. Prior to the improvement, such a query in the URL was not handled properly and it was not possible to connect to a specific database thus one should have to just guess which database would be used (from what I understood, if127.0.0.1IP address is used, the DB name would be127, forlocalhostI was not able to determine which one is used).The PR also bumps the Jackson version to address security vulnerability.