Skip to content

Allow using Firebase RDB emulator with Firebase client#166

Merged
yuri-sergiichuk merged 13 commits intomasterfrom
v1.7.2
Feb 1, 2021
Merged

Allow using Firebase RDB emulator with Firebase client#166
yuri-sergiichuk merged 13 commits intomasterfrom
v1.7.2

Conversation

@yuri-sergiichuk
Copy link
Contributor

@yuri-sergiichuk yuri-sergiichuk commented Jan 30, 2021

This PR fixes the handling of the Firebase RDB emulator endpoint. The DB URL may be of two formats:

  • the https://<database-alias>.firebaseio.com DB URL points to a remote Firebase RDB;
  • the http://<local-ip>:<local-port>?ns=<database-alias> points to a local Firebase RDB emulator.

For the latter, the ns part stands for namespace and is effectively used by the emulator as a way to determine the local database instance to be used. Prior to the improvement, such a query in the URL was not handled properly and it was not possible to connect to a specific database thus one should have to just guess which database would be used (from what I understood, if 127.0.0.1 IP address is used, the DB name would be 127, for localhost I was not able to determine which one is used).

The PR also bumps the Jackson version to address security vulnerability.

@yuri-sergiichuk yuri-sergiichuk added the bug Something isn't working label Jan 30, 2021
@yuri-sergiichuk yuri-sergiichuk requested a review from a team January 30, 2021 14:11
@yuri-sergiichuk yuri-sergiichuk self-assigned this Jan 30, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #166 (cb2be82) into master (28748bf) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     60.14%   60.41%   +0.26%     
- Complexity      210      213       +3     
============================================
  Files            93       93              
  Lines          2366     2382      +16     
  Branches         43       45       +2     
============================================
+ Hits           1423     1439      +16     
  Misses          932      932              
  Partials         11       11              

Copy link
Contributor

@dmdashenkov dmdashenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuri-sergiichuk, LGTM as soon as all the checks pass.

@yuri-sergiichuk yuri-sergiichuk merged commit e270f6b into master Feb 1, 2021
@yuri-sergiichuk yuri-sergiichuk deleted the v1.7.2 branch February 1, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants