Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| || '/subscription/keep-up-all'; | ||
| const request = new Subscriptions() | ||
| request.setSubscriptionList(subscriptions); | ||
| const typed = TypedMessage.of(request) |
There was a problem hiding this comment.
W033: Missing semicolon.
(at-me in a reply with help or ignore)
Codecov Report
@@ Coverage Diff @@
## 1.x-dev #170 +/- ##
=============================================
- Coverage 60.61% 59.66% -0.96%
Complexity 214 214
=============================================
Files 93 95 +2
Lines 2402 2442 +40
Branches 45 46 +1
=============================================
+ Hits 1456 1457 +1
- Misses 935 974 +39
Partials 11 11 |
|
@armiol, PTAL. |
|
@armiol, PTAL. |
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov LGTM in general. Please see my comments.
| * @param {!Array<spine.client.Subscription>} subscriptions subscriptions that are prevented | ||
| * from being closed by the server | ||
| * @return {Promise<Object|SpineError>} a promise of a successful server response JSON data, | ||
| * rejected if the client response is not 2xx or a |
| * {@link SubscriptionBridge}. | ||
| * | ||
| * @param bridge | ||
| * the subscription bridge to be used in to cancel subscriptions |
There was a problem hiding this comment.
I think, we don't need this "in".
| private final SubscriptionBridge<?, ?, ?> bridge; | ||
|
|
||
| /** | ||
| * Creates a new instance of {@code SubscriptionBulkKeepUpServlet} with the given |
There was a problem hiding this comment.
Let's move "the given" to the next line.
|
|
||
| /** | ||
| * Keep up the subscription, prohibiting it from closing from the server-side. | ||
| * Keep up the subscription, preventing it from closing from the server. |
There was a problem hiding this comment.
"Keeps up".
Please address the similar issue in all docs below.
| import static com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| /** | ||
| * An abstract servlet for a client request to keep up an existing {@link Subscription}. |
There was a problem hiding this comment.
"An abstract servlet handling the bulk {@link Subscription} keep-up requests."?
| * {@link SubscriptionBridge}. | ||
| * | ||
| * @param bridge | ||
| * the subscription bridge to be used to keep-up subscriptions |
There was a problem hiding this comment.
Let's settle down on whether we say "to keep up" or "to keep-up".
To me, "keep-up" is a noun and, maybe, an adjective. "To keep up" is a verb.
|
The changes have been published under the version 1.7.4. |
armiol
changed the title
…-1.7.4 [1.x] Bulk keep-up and cancellation requests (port of #170)
2 participants
In this PR we introduce a servlet and client capabilities for batch keep-up requests.
Previously, subscription keep-up requests were sent to the server per subscription, i.e. if the client had one hundred active subscriptions, the server would receive one hundred keep-up requests.
Now, we bundle all those requests into one, so that the network overhead is smaller and the number of HTTP requests to the server is lower.
The network traffic used for such a request is marginally smaller. We still send all the same data to the server and back, but in one fat exchange instead of many small exchanges.
This is a patch to the 1.x version. The "live" 2.x version will receive a similar change but with more structural refactoring as well as a network load improvement over this version.
This PR will not be merged. When the changes are reviewed, I will publish them manually, set up Git tags for the new version, and remove both branches.