Allow specifying arbitrary Runners to use through LWTS#3
Open
Pokechu22 wants to merge 1 commit intoSpongePowered:masterfrom
Open
Allow specifying arbitrary Runners to use through LWTS#3Pokechu22 wants to merge 1 commit intoSpongePowered:masterfrom
Pokechu22 wants to merge 1 commit intoSpongePowered:masterfrom
Conversation
Pokechu22
force-pushed
the
arbitrary-runners
branch
from
166b064 to
aade194
Compare
Pokechu22
force-pushed
the
arbitrary-runners
branch
from
aade194 to
69a1f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using any
Runnerwith LWTS, instead of just the default runner (BlockJUnit4ClassRunner) and theParameterizedrunner. This is done by creating a@DelegatedRunWithannotation that is used to find the runner to run.I create 2 new classes:
DelegateRunnerandLaunchWrapperDelegateRunner.LaunchWrapperDelegateRunneris responsible for loading the class via LaunchWrapper.DelegateRunneris responsible for delegating to another runner by class (either explicitly specified or from@DelegatedRunWith). I separated these mainly because I have a hacky situation where I might want to use@DelegatedRunWithwithout running LaunchWrapper.The existing
LaunchWrapperTestRunnerandLaunchWrapperParameterizedshould work exactly the same as before.