Store friends on FRIENDLIST
#514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gajop
requested changes
Jul 10, 2020
`Interface` had been forwarding the command to `Lobby` but `Lobby` wasn’t handling the list. Now: - updates `self.friends`, `self.friendCount`, and `self.isFriend[userName]` properties - updates `userInfo.isFriend` for the associated user object if they are online. - Hands the friends list to listeners (before, this was the only thing it did, resulting in an un-updated list being handed off) Also, for completeness, `Interface:FriendList()` and `:FriendRequestList()` now forward the calls to `self:super()`. Although this has no meaningful effect, a precedent for this is set with other calls, so this should prevent certain errors should `Lobby` ever care to use these calls.
Member
|
Seems good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a fix for #495
Interfacehad been forwarding the command toLobbybutLobbywasn’t handling the list. Now:self.friends,self.friendCount, andself.isFriend[userName]propertiesuserInfo.isFriendfor the associated user object if they are online.Also, for completeness,
Interface:FriendList()and:FriendRequestList()now forward the calls toself:super(). Although this has no meaningful effect, a precedent for this is set with other calls, so this should prevent certain errors shouldLobbyever care to use these calls.